Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A circuit breaker should not emit 'failure' when short circuiting #45

Closed
lance opened this issue Apr 3, 2017 · 0 comments
Closed

A circuit breaker should not emit 'failure' when short circuiting #45

lance opened this issue Apr 3, 2017 · 0 comments
Assignees
@lance
Labels
bug

Comments

@lance
Copy link
Member

lance commented Apr 3, 2017

Since failures contribute to the errorPercentageThreshold it doesn't really make sense to emit failure when short circuited.
@lance lance added the bug label Apr 3, 2017
@lance lance self-assigned this Apr 3, 2017
@lance lance closed this as completed in ab87350 Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance lance

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lance