Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: docker-compose always exits with exit doe 0 #47

Closed
fearphage opened this issue Mar 9, 2017 · 1 comment
Closed

CI: docker-compose always exits with exit doe 0 #47

fearphage opened this issue Mar 9, 2017 · 1 comment

Comments

@fearphage
Copy link
Contributor

It doesn't matter whether tests fail or not, docker-compose exits with exit code 0.

docker/compose#3379

I tried fixing it with no luck:

  • added tty: true -- tests hang when done
  • changed cmd to sh -c 'npm test; exit $? -- docker-compose still swallowed it
@kr1sp1n
Copy link
Collaborator

kr1sp1n commented Oct 1, 2017

Ok, now I use just docker run to spawn a vault dev server and do a npm run coverage.
Works fine! @fearphage Thanks for reporting this issue 🙏

@kr1sp1n kr1sp1n closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fearphage @kr1sp1n