Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Status Codes other than 200 #273

Merged
merged 2 commits into from Mar 3, 2020
Merged

Handle Status Codes other than 200 #273

merged 2 commits into from Mar 3, 2020

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Mar 3, 2020

  • Handle Status Codes other than 200 (it shouldnt run infinitely anymore if the download fails)
  • Add some TSDoc

this should hopefully fix #226 (at least that what the issue evolved into)

Related Issues

@hasezoey hasezoey added the bug label Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #273 into master will decrease coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   80.33%   79.61%   -0.73%     
==========================================
  Files           9        9              
  Lines         768      775       +7     
  Branches      134      136       +2     
==========================================
  Hits          617      617              
- Misses        150      157       +7     
  Partials        1        1              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde00c9...e718dec. Read the comment docs.

@nodkz
Copy link
Owner

nodkz commented Mar 3, 2020

@hasezoey I'm ready to merge if you don't have any additions.

@hasezoey
Copy link
Collaborator Author

hasezoey commented Mar 3, 2020

@nodkz i think it is ready (i at least couldnt find anything failing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite blockage when version cant be downloaded
2 participants