-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: fetch mongodb on package install #46
Comments
Feel free to create |
Or maybe need to find another solution on your side. Cause Try to add some options which will instruct where to take mongodb bineries offline from your repo. It will be more right way. |
mongo-memory-server-offline package could fetch server during install phase, which will work for virtually everything, except automatic updates. This way package won't be that fat. |
And how it decide which version of mongodb binaries need to install? 3.4, 3.6 |
There are 2 options:
|
Ok, let take 1st case. But rename packages something like:
Where this packages at pre-install will download needed mongo binary to |
As long as you won't have 2 different versions for any package given it's OK to use |
Any update on this issue? |
By default Or you may add some script to your package.json which will execute after package installation: {
"scripts": {
"postinstall": "node ./postinstall.js",
}
} Like it did in this file https://github.com/nodkz/mongodb-memory-server/blob/master/postinstall.js |
I've noticed substantial delay in e2e tests due to on-demand mongodb server download.
On the other hand, on-demand download makes testing without internet access almost impossible because we've to mock 3rd-party infrastructure.
It worth to provide a way to have mongodb server as a part of this npm package or add some optional npm dependency (separate package) to take server from.
The text was updated successfully, but these errors were encountered: