fix(MongoBinaryDownloadUrl): removed ssl from options

[YozhikM]

Referenced to this issue
Now binaries for OSX older than 3.0 version is immediately installed with the SSL. Before and including 3.0 - without.

Since the SSL is not used anywhere else, it is completely removed from the code

[nodkz]

Thanks! 👌👍

PS. Crazy man! When do you sleep?!

[nodkz]

🎉 This PR is included in version 1.7.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[YozhikM]

@nodkz While you're asleep, your enemy increases the level

[mathieug]

Before implementing the ssl option, I started to check the mongodb version like this PR. I think it's better to let the developer to choose.
Maybe you could automatically set the default value but let the user overwrite it.

[nodkz]

@mathieug for information, all available links of MongoDB binaries:
Osx https://www.mongodb.org/dl/osx
Linux https://www.mongodb.org/dl/linux
Win https://www.mongodb.org/dl/win32

ssl option worked only with OSX and if you check available versions of binaries you may see that only several version between 3.0 and 3.4 have both ssl and no ssl binaries. So this option brings more mess than helps.

Can you provide use-case where ssl or no-ssl version is important?

[mathieug]

I know, I have added the ssl option to this package.

I think some users could want to specify ssl or no-ssl with a specific version (between 3.0 and 3.4) and I didn't want to prevent them.
For my use, I don't care I always use the latest version.

[nodkz]

For my use, I don't care I always use the latest version.

Really, for testing purposes (the main aim of this package) it's no matter what type ssl or not-ssl version of binary have been started. It just should work. We had met with the various type of binary URL problems in #55 #51 and maybe several other issues. So the most comfortable and easy way to fix all problems was reducing the logic of determining correct download url. And this decision affected that we deleted ssl option.

I think that YAGNI principle is exactly this case ;)

[mathieug]

I agree since I use the latest version which is only ssl. I just thought it could be this new behaviour by default with still an option to force it.