fix: Fix binary download on debian testing/unstable #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what exactly has this PR to do with the mentioned email thread? please add a test to illustrate what the change is meant to cover. tests can be found here |
|
Updated the commit message, added tests and fixed some more cases. |
hasezoey
requested changes
Aug 17, 2023
packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-memory-server-core/src/__tests__/testUtils/globalSetup.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
=======================================
Coverage 90.38% 90.39%
=======================================
Files 14 14
Lines 1935 1937 +2
Branches 502 503 +1
=======================================
+ Hits 1749 1751 +2
Misses 177 177
Partials 9 9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
VERSION_ID was removed. See https://tracker.debian.org/news/1433360/accepted-base-files-13-source-into-unstable/ and a similar bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1008735
hasezoey
approved these changes
Aug 17, 2023
|
🎉 This PR is included in version 8.15.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.0.0-beta.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERSION_ID was removed. See
https://tracker.debian.org/news/1433360/accepted-base-files-13-source-into-unstable/
and a similar bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1008735