Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing LangevinVAE result in Table 3 #1

Open
qsh-zh opened this issue Jan 13, 2021 · 5 comments
Open

Reproducing LangevinVAE result in Table 3 #1

qsh-zh opened this issue Jan 13, 2021 · 5 comments

Comments

@qsh-zh
Copy link

qsh-zh commented Jan 13, 2021

Thanks for your insightful paper and sharing code.

I run your shared code on experiment 4 MNIST, I can reproduce results claimed in Table 3 except LangevinVAE. It reported NLL around 200 in multiple runs.

I notice there could be a bug in your code, the line misses y in calling interpolated_force. But the results didn't change even I changed to

x1 = x + stepsize * self.interpolated_force(x, y, lambda_) + torch.sqrt(2*stepsize) * torch.randn_like(x)
@franknoe
Copy link
Member

Just spoke with Hao Wu who wrote this code, it's a result of occasional bad proposal step. He will look into details and revise it. Thanks for bringing it up.

@qsh-zh
Copy link
Author

qsh-zh commented Jan 14, 2021

Thanks for your timely response. But according to the paper the mean and covariance of LangevinVAE looks not so bad, not sure it is occasional bad proposal step. I try different random seed, and all reports NLL around 200.

Thanks for you again your insightful paper, it is really a nice work.

@amrhamedp
Copy link

@franknoe
def energy_1(self, x, y):
return (x**2).sum(axis=2, keepdims=True) / 2 - self.G.conditional_log_likelihood(x, y).sum(axis=2, keepdims=True)
The bug is because lambda is passed instead of y and conditional log likelihood is calculated using the lambda value.

@franknoe
Copy link
Member

thank you! Could you send a PR?

@carsonlawrence
Copy link

carsonlawrence commented Dec 8, 2021

Hi there, I’m just following the bread crumbs on this and I’m a bit confused as to the status of the Langevin VAE result in Table 3. Is the result in the paper correct? How should I reproduce it, please? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants