-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing some books info removes whole sdr folder #17
Comments
Well, this is a side effect of the bonus feature that was added after your suggestion.. 😉 But anyway, what happens is not that shocking. After all, the program is warning you that the "selected books' information" will be deleted. The "selected books' information" is the I have to remove the folder, otherwise we end up with What looks confusing, is that I don't clear the other rows (of the same book) too. |
Maybe you didn't noticed but I have not removed all .lua but only those additional. So the original one should have stay there together with the .old. And therefore the sdr folder should not be removed. Also if I have more (5 for example) extra lua file and remove more than one in one DEL press ( 2 for example) whole folder is removed. And yes the rows of the removed extra .lua files are not removed from UI. |
The action that you perform when pressing the |
I see, but wouldn't have it much more sense that you would consider book info only the selected .lua file and delete only that file? If you select the one which is correctly related to a book than you can remove whole folder, because as you correctly wrote, it has no sense to keep the folder if the metadata.*.lua file is not there. I think however if you select to delete not the primary lua file (all those strange file I have there ;-) ), then you should delete only that file. What do you think? |
My problem with this is that it makes the code more complicated for an edge case scenario. |
OK, I do not see in your code so I can understand, but you already have pointer to that particular file once I select merge, isn't it not much more difficult then open and merge a file than only delte it? |
I can always access the file. The problem is that I have to add more checks in the "delete actions" that will complicate and slow down the code (you can delete a lot of files at once). |
Yes I understand. I hate workarounds though, especially as user ;-) |
Hi,
today I discover when I select few lua files belonging to the same book (but not all) and press DEL, KoHighlight will remove whole sdr folder with all lua files. Quite shocking. Please take a look at he screen recording (no audio).
screen-record.mp4
The text was updated successfully, but these errors were encountered: