Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about GetBorderlessBox #105

Open
automata opened this issue May 24, 2016 · 4 comments
Open

Add docs about GetBorderlessBox #105

automata opened this issue May 24, 2016 · 4 comments

Comments

@automata
Copy link
Member

Since GetBorderlessBox is a heuristic based implementation, with many params and relations between image features (e.g. dimensions, intensities), would be interesting to add docs explaining both heuristics and examples of positive/negative cases (crop/don't crop).

@jonnor
Copy link
Member

jonnor commented May 24, 2016

If you use fbp-spec you'll have a structured test format, which you can generate documentation from. ;)

@automata
Copy link
Member Author

@jonnor great idea! Sounds like a good start for fbp-specing all image related tests!

@GabiThume ☝️

@jonnor
Copy link
Member

jonnor commented May 24, 2016

This is quite related to the idea of a visual "datasheet" for a component, ref noflo/noflo-ui#51

@automata
Copy link
Member Author

Oh wow that's cool. Really related, I can imagine some sketches/diagrams/images explaining the heuristics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants