Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play nice with GIFs #17

Open
nogarcia opened this issue Jul 5, 2019 · 1 comment
Open

Play nice with GIFs #17

nogarcia opened this issue Jul 5, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@nogarcia
Copy link
Owner

nogarcia commented Jul 5, 2019

Describe the bug
When downloading an animated comic, the script downloads the bytes and names them as a PNG. The file fails to load in an image editor. 1264 is a still image in ImageMagick. The file is verifiably a GIF when viewed in a hex editor.

To Reproduce
Steps to reproduce the behavior:
1.

$ xkcdn --num 1264 # any animated comic
  1. Open the file in EOG or any other image viewer.

Expected behavior
The image is recognized as a GIF and is aptly named.

Desktop (please complete the following information):

  • OS: Ubuntu 18.04.1 LTS
  • Version: latest
@nogarcia nogarcia added the bug Something isn't working label Jul 5, 2019
@nogarcia
Copy link
Owner Author

nogarcia commented Jul 5, 2019

I converted the file in bytes to a string. The first five characters are "b'GIF".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant