Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 4 config file ignored #7

Closed
spib opened this issue Aug 21, 2013 · 3 comments
Closed

Laravel 4 config file ignored #7

spib opened this issue Aug 21, 2013 · 3 comments
Labels

Comments

@spib
Copy link

spib commented Aug 21, 2013

Hi,

I published the config file within laravel 4

php artisan config:publish noherczeg/breadcrumb

Made some changes, but the changes don't take effect. It looks to me like you aren't ever referencing the package config file.

I was able to make it work by adding the following line to BreadCrumb\Config.php around line 47 in the value() method

    if (!is_string($key)) {
            throw new \InvalidArgumentException("Invalid argument provided, string required!");
    }
    elseif(\Config::get('breadcrumb::' . $key, false) !== false) {
            return \Config::get('breadcrumb::' . $key, false);
    }
    // as before

Doing this and removing the namespace declaration from the generated config file worked for me but not sure what effect this would have on people using it outside of laravel

@noherczeg
Copy link
Owner

Greetings!

When I get home I'll test it out, and will merge your fix!

Thank you for your feedback!

@noherczeg
Copy link
Owner

Hey again!

First of all, I'm terribly sorry for the delay!

I just tried out your solution to the problem and it seems fine to me. I didn't even need to remove the namespace declaration yet it seems to work correctly. I don't have my ssh key with me now, so I'll push the fix when I get back home.

Thanks again for the response!

@noherczeg
Copy link
Owner

Fix has been applied!

Thanks spib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants