Skip to content
This repository has been archived by the owner on Sep 20, 2018. It is now read-only.

Fix all bugs introduced with 5.0.13 and 5.0.12 #2

Closed
NoHomey opened this issue Oct 22, 2016 · 1 comment
Closed

Fix all bugs introduced with 5.0.13 and 5.0.12 #2

NoHomey opened this issue Oct 22, 2016 · 1 comment
Assignees
Milestone

Comments

@NoHomey
Copy link
Owner

NoHomey commented Oct 22, 2016

There have been several bugs introduced with 5.0.13 and 5.0.12 releases:

Both 5.0.12 5.0.13 and tried to fix a bug where onError, onValid and onRequestValue are not called when either of there props: min, max, required and strategy changes. But instead they just introduced more bugs which let to onError to not be called on time and old props to be used.

The fix of these bugs is to change all methods that reference this.props to accept props: NumberInputProps argument passed to them which means that those methods that don't reference this other than for props should be made static.

@NoHomey NoHomey added this to the Bugs milestone Oct 22, 2016
@NoHomey NoHomey self-assigned this Oct 22, 2016
@NoHomey
Copy link
Owner Author

NoHomey commented Oct 22, 2016

#3 fixes this.

NoHomey added a commit that referenced this issue Oct 22, 2016
Fixes #2 Fix all bugs introduced with 5.0.13 and 5.0.12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant