LuaPushable is not implemented for std::string::String

[Avimitin]

Sorry to bother you, again. The LuaPushable trait is not implemented for std::string::String, so Vec is still not a LuaPushable object. It seems like we need to implement this function. https://www.lua.org/manual/5.1/manual.html#lua_pushlstring

[Avimitin]

Manage to make it work, but I don't know if it is correct to cast const *u8 to const *i8

diff --git a/crates/luajit-bindings/src/pushable.rs b/crates/luajit-bindings/src/pushable.rs
index 39876f2..3e68c92 100644
--- a/crates/luajit-bindings/src/pushable.rs
+++ b/crates/luajit-bindings/src/pushable.rs
@@ -127,6 +127,17 @@ impl<T: LuaPushable> LuaPushable for Vec<T> {
     }
 }
 
+impl LuaPushable for String {
+    unsafe fn push(
+            self,
+            lstate: *mut lua_State,
+        ) -> Result<c_int, crate::Error> {
+        ffi::lua_pushlstring(lstate, self.as_ptr() as _, self.len() as _);
+
+        Ok(1)
+    }
+}
+
 /// Implements `LuaPushable` for a tuple `(a, b, c, ..)` where all the elements
 /// in the tuple implement `LuaPushable`.
 macro_rules! push_tuple {

[Avimitin]

It seems like Mlua crate is also using &[u8] for String

[noib3]

closed by 79130ba