Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Restify #272

Closed
Gby56 opened this issue Apr 11, 2024 · 3 comments · Fixed by #273
Closed

Support Restify #272

Gby56 opened this issue Apr 11, 2024 · 3 comments · Fixed by #273
Labels
🔬 analyzer Issue for Analyzer 🔎 detector Issue for Detector 💊 spec Issue for test codes
Milestone

Comments

@Gby56
Copy link
Contributor

Gby56 commented Apr 11, 2024

Hi ! I was checking the list of supported frameworks, seems like Restify is not there yet, I might make a PR later :)
http://restify.com/

@Gby56
Copy link
Contributor Author

Gby56 commented Apr 11, 2024

@hahwul I'm not familiar at all with Crystal but I'm getting an error when building, even from scratch

EDIT: This is caused by a version of Crystal that was too recent. Seems like Crest only works on 1.11x

shards build --error-trace

In src/deliver/send_proxy.cr:22:26

 22 | Crest::Request.execute(
                     ^------
Error: instantiating 'Crest::Request.execute(method: Symbol, url: String, p_addr: (String | Nil), p_port: (Int32 | Nil), tls: OpenSSL::SSL::Context::Client, user_agent: String, params: Hash(String, String), headers: Hash(String, String), form: Hash(String, String), json: Bool)'
.....

In lib/http_proxy/src/ext/http/client.cr:11:28

 11 | @io = proxy_client.open(
                         ^---
Error: no overload matches 'HTTP::Proxy::Client#open', host: String, port: Int32, tls: (OpenSSL::SSL::Context::Client | Nil), dns_timeout: (Time::Span | Nil), connect_timeout: (Time::Span | Nil), read_timeout: (Time::Span | Nil), write_timeout: (Time::Span | Nil)

Overloads are:
 - HTTP::Proxy::Client#open(host, port, tls = nil, *, dns_timeout : ::Float64 | ::Nil, connect_timeout : ::Float64 | ::Nil, read_timeout : ::Float64 | ::Nil, write_timeout : ::Float64 | ::Nil)
Couldn't find overloads for these types:

@hahwul
Copy link
Member

hahwul commented Apr 12, 2024

Hiya @Gby56

Thank you so much for your wonderful ideas and contributions!

I apologize for the late response as I am currently on a restful vacation 😭

I've taken a quick look at the PR you sent. I'll be on vacation until next week, but once I'm back, I'll roll up my sleeves and do my best to ensure your suggestions can be integrated into the main code!

Thanks again! Have a great day.

@hahwul hahwul added this to the NextVersion milestone Apr 12, 2024
@hahwul hahwul added 🔎 detector Issue for Detector 🔬 analyzer Issue for Analyzer 💊 spec Issue for test codes labels Apr 12, 2024
@hahwul
Copy link
Member

hahwul commented Apr 29, 2024

Released v0.15.0. Closing the issue.

@hahwul hahwul closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔬 analyzer Issue for Analyzer 🔎 detector Issue for Detector 💊 spec Issue for test codes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants