Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

feat: replace downloader dependency with reqwest #114

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

TomAFrench
Copy link
Member

This PR replaces downloader with reqwest

This results in the progress bar being displayed as below:

// Downloader
Downloading the Ignite SRS (340MB)

[00:00:17] ######################################## 322560348/322560348 
Downloaded the SRS successfully!
Time Elapsed: 17 seconds

// Reqwest
Downloading the Ignite SRS (340MB)

[00:00:17] ######################################## 307.62 MiB/307.62 MiB Downloaded the SRS successfully!
SRS is located at: "/home/tom/.nargo/backends/acvm-backend-barretenberg/transcript00.dat"

The "Downloaded the SRS successfully!" message only appears on completion of the download. I've removed the "Time Elapsed" line as this is displayed in the progress bar.

Resolves #47

common/Cargo.toml Outdated Show resolved Hide resolved
@TomAFrench TomAFrench force-pushed the downloader-crate-removal branch 2 times, most recently from 2696aff to 7392a8c Compare April 14, 2023 11:24
@TomAFrench TomAFrench requested a review from phated April 14, 2023 11:35
@TomAFrench
Copy link
Member Author

TomAFrench commented Apr 14, 2023

This PR just aims to be a seamless replacement for the downloader crate. We can revisit with avoiding panics in future.

Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this locally, but let's get it landed to avoid additional churn while we do the refactors.

@phated phated added this pull request to the merge queue Apr 17, 2023
Merged via the queue into master with commit dd62231 Apr 17, 2023
7 checks passed
@phated phated deleted the downloader-crate-removal branch April 17, 2023 23:18
TomAFrench added a commit that referenced this pull request Apr 17, 2023
* master:
  feat: replace `downloader` dependency with `reqwest` (#114)
@github-actions github-actions bot mentioned this pull request May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace downloader crate
2 participants