This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
feat!: remove dead blake2 code #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc'ing @kevaundray to make sure we don't want to use bb |
kevaundray
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Thanks for the CC @phated -- @TomAFrench yeah this looks correct, in common/black_box_functions, we use the rust version -- Note, blake is also used in HashToField in the blackbox function file
It is ok this can be removed |
phated
approved these changes
Apr 25, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 25, 2023
* master: feat!: remove dead blake2 code (#137)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't make use of barretenberg to perform this hashing so we can remove it and continue using the rust implementation from ACVM instead.
https://github.com/noir-lang/aztec_backend/blob/7281750ae4d265f2d81a0eaad8a654d38133e1d5/common/src/black_box_functions.rs#L28
Alternatively, we could retain this just for testing that this implementation matches Barretenberg but that seems overkill to me.
Related to #136