Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for contract artifact output #1159

Open
TomAFrench opened this issue Apr 17, 2023 · 1 comment
Open

Add integration test for contract artifact output #1159

TomAFrench opened this issue Apr 17, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TomAFrench
Copy link
Member

The PR #1126 resulted in a regression due to insufficient testing on the contract artifacts being saved to disk. This was fixed in #1158 but it was brought up that:

I wonder if we can have PR artifacts that show what the ABI looks like, or possibly some ABI artifact that gets checked in and the CI checks if they match

Originally posted by @kevaundray in #1158 (comment)

We should add an integration test which checks the build artifacts from a set Noir project against some checked in examples in order to avoid this happening in future.
@TomAFrench TomAFrench added enhancement New feature or request good first issue Good for newcomers labels Apr 17, 2023
@ameya-deshmukh
Copy link

Would love to take this up @TomAFrench!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TomAFrench @kevaundray @Savio-Sou @ameya-deshmukh