Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssa refactor): Fix failed_to_inline_a_function being set for intrinsics #1675

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 13, 2023

Description

Problem*

The change to add handling for brillig functions changed failed_to_inline_a_function to be true whenever a function failed to inline. We want this not to be set if the function we found is an intrinsic since those do not need to be inlined and added a comment since this is otherwise a subtle difference.

Fixes #1659

Summary*

This PR sets out to

Example

Before:


After:


Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from joss-aztec June 13, 2023 17:21
@jfecher
Copy link
Contributor Author

jfecher commented Jun 13, 2023

Just confirmed this PR results in exactly 1 function in the final IR for every example mentioned in #1659, however it is worth noting that all of these examples are still failing for other reasons.

Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joss-aztec joss-aztec added this pull request to the merge queue Jun 14, 2023
Merged via the queue into master with commit 377ac5c Jun 14, 2023
9 checks passed
@joss-aztec joss-aztec deleted the jf/fix-inlining branch June 14, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functions not fully inlined
2 participants