Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract should be a CrateType instead of a flag and specified in Nargo.toml #2075

Closed
Tracked by #2162
phated opened this issue Jul 27, 2023 · 1 comment · Fixed by #2204
Closed
Tracked by #2162

Contract should be a CrateType instead of a flag and specified in Nargo.toml #2075

phated opened this issue Jul 27, 2023 · 1 comment · Fixed by #2204
Assignees
@phated
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Jul 27, 2023

Problem

Currently, contracts are only supported by some nargo commands and they require a special flag. This seems counter-intuitive because a contract package is always a contract package. This should be configured inside a Nargo.toml file instead and supported across all commands.

Happy Case

A crate can be configured as a "contract crate type" and all commands will use the logic to compile contracts.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phated phated

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nargo)!: Replace --contracts flag with contract package type noir-lang/noir
2 participants
@phated @kevaundray