Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate trait implementations with attributes #2629

Closed
1 task
Maddiaa0 opened this issue Sep 11, 2023 · 1 comment
Closed
1 task

Investigate trait implementations with attributes #2629

Maddiaa0 opened this issue Sep 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Sep 11, 2023 •
edited by Savio-Sou
Loading

Soft Prerequisite
Beta Give feedback
  1. Epic: Implement Traits #2568
    9 of 11

Problem

While implementing custom / multiple attributes work, it did not appear that traits currently had any notion of an attribute. This issue serves as a bookmark to revisit this once traits are more mature.

The relevant code that sparked this thought:

noir/crates/noirc_frontend/src/hir/def_collector/dc_mod.rs

Line 216 in 6db3bda

if let TraitItem::Function {

Happy Case

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@Maddiaa0 Maddiaa0 added the enhancement New feature or request label Sep 11, 2023
@Maddiaa0 Maddiaa0 mentioned this issue Sep 11, 2023
Merged
@kevaundray kevaundray mentioned this issue Sep 11, 2023
Open
46 tasks
@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
@TomAFrench
Copy link
Member

Closing in favour of #3301

@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2024
@TomAFrench TomAFrench removed this from the 1.0 milestone Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TomAFrench @kevaundray @Maddiaa0