fix: Use plain integer addresses for opcodes in DAP disassembly view #4941
+145
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning serialized opcode locations is invalid according to the DAP specification and confuses VS.Code.
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #4904
The disassembly view from VS.Code didn't work properly. Sometimes it would only show the first opcode only and once open it wouldn't update the current opcode pointer when stepping through the code. This was because we were using opcode locations (eg.
3.17) as instruction references (typed as string in the API), but VS.Code expects integers either in decimal or hexadecimal format.Summary*
This PR updates the disassembly request DAP command handler to return integer addresses only, and changes the instruction set breakpoint command to parse and map the given address to the appropriate opcode location.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.