Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hir -> Ast pass losses full names of variables #4915

Closed
Tracked by #4594
jfecher opened this issue Apr 24, 2024 · 1 comment
Closed
Tracked by #4594

Hir -> Ast pass losses full names of variables #4915

jfecher opened this issue Apr 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Apr 24, 2024

Aim

Running the Hir -> Ast pass on a program for metaprogramming

Expected Behavior

If the Hir had no errors then the resulting Ast should not either

Bug

Paths are lost in the Hir so the resulting names in the Ast may not re-resolve correctly

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the bug Something isn't working label Apr 24, 2024
@jfecher
Copy link
Contributor Author

jfecher commented May 30, 2024

The Hir -> Ast pass is no longer needed and will be removed.
Due to architectural changes (elaborator instead of a looping architecture) this pass is no longer necessary.

@jfecher jfecher closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant