Ignition timing changed to be calculated directly from ingnition end angle (previous art was endAngle -> startAngle -> endtime)

Other channels left as is at the moment.

Initial work on refactoring ignition schedules

Reduced code repetition.

Updated interrupt functions on all channels to be compatible with the previous changes to the interrupt schedulers.
Reduced code repetition in ignition interrupt functions.

Only allow the overdwell protection in the timers.ino to run when it is enabled and with the new ignition mode(to increase performance).
For old ignition mode incorporate the overdwell protection to the schedulers.
Plus some comments tweaked in scheduler.ino

Rearranged the angleToTime in the setIgnitionShedule() only calculated when it is really needed. Now it is not calculated when corresponding schedule is already running, this saves some time and may help on atmega platvorm since those calculations include division.

Time window between staging and impulse starting interrupts was too small for the Atmega to keep up. Just add a little extra time.
Plus make setIgnitionxCompare functions use COMPARE_TYPE, for possible future multi platvorm differences.

Adds extra parentheses around the macro argument.

Put default envs back to the megaatmega2560. Should not have been changed in the first place, would be cleaner PR.

Change some more variables type to COMPARE_TYPE. Currently all timer comparators are used with 16bit. So the COMPARE_TYPE is currently uint16_t. Anyway when possibly changing the COMPARE_TYPE in the future, great care must be taken to evaluate all effects. This just adds a little bit closer to make smooth changing of COMPARE_TYPE possible.

Organize variables to use COMPARE_TYPE definition in some more places. With intention to make schedulers compatible with different width timers comparators.

The inline specifier is only a compiler hint, and the compiler is free to completely ignore it. Compilers that we are using today actually are supposed to do the inlining automatically without this specifier too, but for good measure still add it.

…o Testimiseks

For cleaner and shorter code, remove the multiple global variables and place the same functionality inside the existing struct. The ignitionSchedule struct now has new member.
Basically done with intention to reduce arguments count of setIgnitionSchedule function after that.

reduce setIgnitionSchedule function arguments count by 1.
  channelIgnDegrees are now taken directly from corresponding ignitionSchedule struct

Convert small "getIgnCoutenter()" functions also to the COMPARE_TYPE.

Fix Fixed Cranking Override for all decoders.
Previously there was excessice dwell and spark produced at trigger edge. Changed that so that now coil charging is started at trigger edge and normal dwell is used. This retards the timing slightly for starting-- should be a good thing. (For most decoders that use fixed timing for starting the trigger edge should be at 5degrees BTDC).

Prevent per tooth ignition from running with fixed cranking ignition override

Add decoderHasFixedCrankingTiming = true; on some decoders that had that missing.

Do not allow per tooth ignition mode to run during the fixedcrankingtiming on all triggers that support both.

Add decoderHasFixedCrankingTiming = true; on some decoders that had that missing.

Remove unused variables:
int ignition1StartAngle
int ignition2StartAngle
int ignition3StartAngle
int ignition4StartAngle
int ignition5StartAngle
int ignition6StartAngle
int ignition7StartAngle
int ignition8StartAngle
All those angles are not used any more. All things are based on ignitionEndAngles(actual spark angle).

affected files: speeduino.ino; globals.h

Cleaner code. Remove dwell angle from calculateIgnitionAngle() function arguments, since this is actually unused. Dwell is based directy on dwell time.

Remove "fixedCrankingOverride" variable because it it not used any more. It was previously used to regulate dwell during fixed cranking timing, but now the dwell is regulated in the schedulers.

Those function declarations were still not updated. Functions themselves were already updated earlier.

Use functions to set the ignition compare values with the perToothTiming. This fixes the some kind of type conversion issue that caused occassional very early spark events previously.

Add cast to COMPARE_TYPE also for idle. Similar issue of that cast missing was causing issues with the ignition timing. This is needed when 32bit timer is used in the 16bit overflow mode. So apply it here too.

Move IgnitionStartFunction and IgnitionEndFunction to be with the ignition schedule struct. Reduced code repetition.
0.1% RAM saving, 0.1% Flash saving observed on black_F407VE