Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Env Version Default #707

Closed
acatejr opened this issue May 11, 2022 · 2 comments
Closed

Node Env Version Default #707

acatejr opened this issue May 11, 2022 · 2 comments
Labels
enhancement Feature request
Milestone

Comments

@acatejr
Copy link

acatejr commented May 11, 2022

Description

The new feature that shows the node env (nvm) version is enabled by default. Although a good enhancement, I spend most of my time in python and do not have a primary concern that the node version is displayed by default.

How will this be useful?

Disabling the node version as default on, for me, would reduce visual noise on the command line.

Example prompt

[userid:~/workspace/github.com/myid/projectname] branch:

NOT:
[userid:~/workspace/github.com/myid/projectname][node version number] branch:

@acatejr acatejr added the enhancement Feature request label May 11, 2022
@Rycieos
Copy link
Collaborator

Rycieos commented May 11, 2022

I had enabled it by default as it has no performance detriment and it would only show up if a user had Node.js stuff specifically installed. And it is quite simple to disable.

But I can see the argument, and generally new stuff is disabled by default if it is not something everyone would want to use. I will probably make this change before 2.1 is released unless I get other feedback.

@Rycieos Rycieos added this to the v2.1 milestone May 11, 2022
@acatejr
Copy link
Author

acatejr commented May 13, 2022

Thank you. I did find how to disable in liquidpromptrc. So, it may not be worth your time to make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request
Projects
None yet
Development

No branches or pull requests

2 participants