Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change incorrect reference from 'kanji' to 'katakana' #5

Merged
merged 2 commits into from Oct 29, 2019

Conversation

foggy1
Copy link
Contributor

@foggy1 foggy1 commented Dec 19, 2018

The characters that currently show up when a user elects to use the kanji option are not actually kanji (the Chinese characters used in the Japanese writing system), but rather katakana (one of the Japanese phonetic alphabets).

("Kangxi" radicals are in the unicode spec from 0x2F00-0x2FDF)

Copy link
Owner

@nojvek nojvek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Somehow I missed this. Approved

@nojvek nojvek merged commit ca0f662 into nojvek:master Oct 29, 2019
@foggy1 foggy1 deleted the fix-japanese-character-name branch November 26, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants