Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None type IP allocation fails for allowed delegates #107

Closed
Levovar opened this issue Jul 12, 2019 · 0 comments · Fixed by #110
Closed

None type IP allocation fails for allowed delegates #107

Levovar opened this issue Jul 12, 2019 · 0 comments · Fixed by #110
Labels
bug Something isn't working
Milestone

Comments

@Levovar
Copy link
Collaborator

Levovar commented Jul 12, 2019

Which basically only concerns SR-IOV: it works with IPVLAN, it already wasn't allowed for MACVLAN because it would not work at all, and all the static delegates handle their IPAM on their own; they are not integrated to DANM IPAM.
(Hmm, now that I think about it, they actually could be. How awesome that would be :) Anyway, other thread)

The problem is that when we want no IPs on the interface, we create an "ipam" section with only "type: fakeipam" attribute set.
However, that prompts the CNI to call the CNI IPAM package, at which point we will expect some IPs to be allocated.
Based on upstream:
https://github.com/intel/sriov-cni/blob/master/cmd/sriov/main.go#L77
the correct behaviour is to forego adding the whole IPAM section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant