fix: collapse skin tone picker on blur #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16
I tested in all three engines in macOS and Ubuntu, as well as iOS Safari, macOS Safari VoiceOver, and NVDA Firefox on Windows. I tested blurring by clicking outside of the skin tone picker, as well as using both the mouse/touch and enter/spacebar to select the buttons. I learned a lot of somewhat arcane things about how browsers handle this stuff.
First off,
<button>s behave differently in iOS Safari and Safari/Firefox on Mac. See https://stackoverflow.com/a/42764495/680742 and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#Clicking_and_focus andSecond off, apparently the way buttons work is that Enter fires on keydown and spacebar fires on keyup. Because it wouldn't be the web if things weren't wildly unpredictable. 馃檭 https://lists.w3.org/Archives/Public/w3c-wai-ig/2019JanMar/0086.html
In any case, this seems to cover all cases, although I should probably test all 3 engines on Windows to be safest.