Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix setting props before element upgrade #194

Merged
merged 3 commits into from Jul 26, 2021
Merged

Conversation

nolanlawson
Copy link
Owner

fixes #190

@github-actions
Copy link

github-actions bot commented Jul 26, 2021

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-first-load: unsure 🔍 -10% - +9% (-7.76ms - +6.88ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -8% - +9% (-6.14ms - +6.46ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
73.54ms - 83.56ms-unsure 🔍
-10% - +9%
-7.76ms - +6.88ms
tip-of-tree
tip-of-tree
73.65ms - 84.33msunsure 🔍
-9% - +10%
-6.88ms - +7.76ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
70.27ms - 78.54ms-unsure 🔍
-8% - +9%
-6.14ms - +6.46ms
tip-of-tree
tip-of-tree
69.50ms - 79.00msunsure 🔍
-9% - +8%
-6.46ms - +6.14ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented Jul 26, 2021

Size Change: +114 B (0%)

Total Size: 41.6 kB

Filename Size Change
./bundle.js 41.6 kB +114 B (0%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting props before custom element upgrade doesn't work
1 participant