Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Object.prototype.hasOwnProperty #198

Merged
merged 1 commit into from Aug 2, 2021
Merged

Conversation

nolanlawson
Copy link
Owner

After reading https://eslint.org/docs/rules/no-prototype-builtins, I realized I was doing this slightly wrong. Although it probably doesn't matter, and it's probably safe to use this.hasOwnProperty. But I guess to play it safe I'll abide by the rule.

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-first-load: unsure 🔍 -8% - +8% (-6.75ms - +7.08ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -9% - +3% (-7.91ms - +2.42ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
79.45ms - 89.24ms-unsure 🔍
-8% - +8%
-6.75ms - +7.08ms
tip-of-tree
tip-of-tree
79.30ms - 89.06msunsure 🔍
-8% - +8%
-7.08ms - +6.75ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
80.53ms - 87.75ms-unsure 🔍
-9% - +3%
-7.91ms - +2.42ms
tip-of-tree
tip-of-tree
83.20ms - 90.58msunsure 🔍
-3% - +10%
-2.42ms - +7.91ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

Size Change: +10 B (0%)

Total Size: 41.6 kB

Filename Size Change
./bundle.js 41.6 kB +10 B (0%)

compressed-size-action

@nolanlawson nolanlawson merged commit b8302b2 into master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant