Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use IDBObjectStore.clear #208

Merged
merged 1 commit into from Aug 13, 2021
Merged

perf: use IDBObjectStore.clear #208

merged 1 commit into from Aug 13, 2021

Conversation

nolanlawson
Copy link
Owner

There's no need to do separate objectStore.delete()s when we can just call objectStore.clear().

@github-actions
Copy link

github-actions bot commented Aug 13, 2021

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-first-load: unsure 🔍 -7% - +7% (-4.90ms - +5.36ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -7% - +9% (-5.55ms - +6.64ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
69.30ms - 76.49ms-unsure 🔍
-7% - +7%
-4.90ms - +5.36ms
tip-of-tree
tip-of-tree
69.01ms - 76.32msunsure 🔍
-7% - +7%
-5.36ms - +4.90ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
70.60ms - 79.02ms-unsure 🔍
-7% - +9%
-5.55ms - +6.64ms
tip-of-tree
tip-of-tree
69.86ms - 78.67msunsure 🔍
-9% - +7%
-6.64ms - +5.55ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

Size Change: -61 B (0%)

Total Size: 41.5 kB

Filename Size Change
./bundle.js 41.5 kB -61 B (0%)

compressed-size-action

@nolanlawson nolanlawson merged commit ed0ffac into master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant