Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: used dark colors for scrollbar in dark mode #294

Merged
merged 1 commit into from Oct 23, 2022
Merged

fix: used dark colors for scrollbar in dark mode #294

merged 1 commit into from Oct 23, 2022

Conversation

Mavrin
Copy link
Contributor

@Mavrin Mavrin commented Oct 23, 2022

before fix:
Screenshot 2022-10-23 at 14 44 34
after fix:
Screenshot 2022-10-23 at 14 44 46

@nolanlawson
Copy link
Owner

Tested in Chrome on Linux, LGTM!

Screenshot from 2022-10-23 10-21-57

Screenshot from 2022-10-23 10-22-25

One thing I was confused about (after reading this post) is whether we should do color-scheme: dark light rather than color-scheme: dark, but it seems like it doesn't really make a difference in any browser/OS/settings combo.

Thanks again!

@nolanlawson nolanlawson merged commit af959ae into nolanlawson:master Oct 23, 2022
@Mavrin Mavrin deleted the fix_dark_mode branch October 23, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mavrin @nolanlawson