Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simpler solution to avoid svelte invalidations #303

Merged
merged 2 commits into from Dec 18, 2022

Conversation

nolanlawson
Copy link
Owner

Moving to a function outside of the Svelte component avoids Svelte adding invalidations

@github-actions
Copy link

github-actions bot commented Dec 18, 2022

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-database-interactions: unsure 🔍 -2% - +6% (-4.49ms - +11.17ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -2% - +10% (-1.86ms - +7.41ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -9% - +6% (-7.03ms - +4.82ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
183.80ms - 195.51ms-unsure 🔍
-2% - +6%
-4.49ms - +11.17ms
tip-of-tree
tip-of-tree
181.12ms - 191.52msunsure 🔍
-6% - +2%
-11.17ms - +4.49ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
78.33ms - 84.87ms-unsure 🔍
-2% - +10%
-1.86ms - +7.41ms
tip-of-tree
tip-of-tree
75.54ms - 82.11msunsure 🔍
-9% - +2%
-7.41ms - +1.86ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
75.79ms - 84.18ms-unsure 🔍
-9% - +6%
-7.03ms - +4.82ms
tip-of-tree
tip-of-tree
76.91ms - 85.27msunsure 🔍
-6% - +9%
-4.82ms - +7.03ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

Size Change: +13 B (0%)

Total Size: 41.8 kB

Filename Size Change
./bundle.js 41.8 kB +13 B (0%)

compressed-size-action

@nolanlawson nolanlawson merged commit 4af86a8 into master Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant