feat: support attribute format for some properties #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the bundlesize has increased too much. I may need to decrease it elsewhere to buy us wiggle room. |
nolanlawson
force-pushed
the
better-attribute-behavior
branch
from
c3bcf11
to
86acd67
Compare
|
Holding off on merging until I'm ready to publish, since it will update the README as well. |
This allows users to set the locale, data source, and skin tone emoji using HTML attributes as well as properties. Fixes #7
nolanlawson
force-pushed
the
better-attribute-behavior
branch
from
86acd67
to
c26a17f
Compare
|
Looks like sveltejs/svelte#4860 increased the bundle size a bit. C'est la vie, I bumped the max size from 40kB to 40.5kB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to set the locale, data source, and skin tone emoji using HTML attributes as well as properties.
Fixes #7