Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: hoist global check #358

Merged
merged 1 commit into from Jun 30, 2023
Merged

perf: hoist global check #358

merged 1 commit into from Jun 30, 2023

Conversation

nolanlawson
Copy link
Owner

Small optimization on top of #357

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-database-interactions: unsure 🔍 -2% - +4% (-4.13ms - +6.86ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -1% - +9% (-0.51ms - +7.73ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -2% - +9% (-1.10ms - +7.27ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
176.82ms - 183.80ms-unsure 🔍
-2% - +4%
-4.13ms - +6.86ms
tip-of-tree
tip-of-tree
174.70ms - 183.18msunsure 🔍
-4% - +2%
-6.86ms - +4.13ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
83.25ms - 89.22ms-unsure 🔍
-1% - +9%
-0.51ms - +7.73ms
tip-of-tree
tip-of-tree
79.79ms - 85.46msunsure 🔍
-9% - +0%
-7.73ms - +0.51ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
79.02ms - 84.92ms-unsure 🔍
-2% - +9%
-1.10ms - +7.27ms
tip-of-tree
tip-of-tree
75.91ms - 81.86msunsure 🔍
-9% - +1%
-7.27ms - +1.10ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

Size Change: +12 B (0%)

Total Size: 42.6 kB

Filename Size Change
./bundle.js 42.6 kB +12 B (0%)

compressed-size-action

@nolanlawson nolanlawson merged commit 60eeb8e into master Jun 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant