Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid newer JS syntax to support old Safari #380

Merged
merged 2 commits into from Nov 24, 2023

Conversation

nolanlawson
Copy link
Owner

Fixes #379

Avoids breaking old browsers by avoiding the optional chaining (?.) syntax.

Copy link

github-actions bot commented Nov 24, 2023

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-database-interactions: unsure 🔍 -2% - +2% (-2.11ms - +2.22ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -3% - +4% (-1.33ms - +1.80ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -5% - +3% (-1.95ms - +1.23ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
89.21ms - 92.13ms-unsure 🔍
-2% - +2%
-2.11ms - +2.22ms
tip-of-tree
tip-of-tree
89.02ms - 92.21msunsure 🔍
-2% - +2%
-2.22ms - +2.11ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
41.90ms - 44.25ms-unsure 🔍
-3% - +4%
-1.33ms - +1.80ms
tip-of-tree
tip-of-tree
41.81ms - 43.87msunsure 🔍
-4% - +3%
-1.80ms - +1.33ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
40.14ms - 42.24ms-unsure 🔍
-5% - +3%
-1.95ms - +1.23ms
tip-of-tree
tip-of-tree
40.35ms - 42.74msunsure 🔍
-3% - +5%
-1.23ms - +1.95ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

github-actions bot commented Nov 24, 2023

Size Change: -21 B (0%)

Total Size: 42.8 kB

Filename Size Change
./bundle.js 42.8 kB -21 B (0%)

compressed-size-action

@nolanlawson
Copy link
Owner Author

Oops, forgot this was only added for the svelte.js build... need something else to actually fix #379.

@nolanlawson nolanlawson changed the title fix: expand optional chaining in ensure_array_like_shim fix: avoid newer JS syntax to support old Safari Nov 24, 2023
@nolanlawson nolanlawson merged commit 77e6e35 into master Nov 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant