perf: use lazy image loading #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing in Chrome, this works quite well. As you scroll, custom emoji are loaded lazily.
In Firefox, it doesn't work well at all, but this is no worse than the status quo of loading all images eagerly at once. Probably FF needs to tweak their algorithm for inner scrollers as opposed to document scrollers.
Safari does not support this yet but it's behind a flag.
For the favorites bar it doesn't matter much since the favorites bar is always visible. But I keep it for consistency and because maybe people have the emoji-picker in a place where it's not immediately visible, so lazy-loading makes sense in that case.