Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace for performance entries? #12

Closed
nolanlawson opened this issue Mar 4, 2017 · 2 comments
Closed

Namespace for performance entries? #12

nolanlawson opened this issue Mar 4, 2017 · 2 comments

Comments

@nolanlawson
Copy link
Owner

Arguably marky shouldn't clear all the entries in marky.clear(), only its own. But this would require changing the current mark/measure system to prefix all marks, as suggested here: w3c/resource-timing#89 (comment)

Thus far I've assumed with marky that overall usage of the User Timing API is low enough that there is little danger of collisions; in fact my goal was to increase visibility of the UT API and get people to start using it. :) But as more libraries like React and Vue start to use it themselves, it may make sense to namespace. Arguably it would become a breaking change though.

@gokatz
Copy link

gokatz commented Apr 4, 2017

@nolanlawson, the same goes for name which is given to measure API, right ?

@nolanlawson
Copy link
Owner Author

I probably won't get around to this, although it is an interesting idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants