Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Some concurrency fixes, some configurability #109

Closed
1 of 5 tasks
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
1 of 5 tasks

[PR] Some concurrency fixes, some configurability #109

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive refactoring Code cleanup without new features added

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by dbazhal at 2019-06-12 15:56:18+00:00
Original URL: zalando-incubator/kopf#109
Merged by nolar at 2019-06-21 08:24:55+00:00

Trying to fix blocking operations, such as objects patching, event posting, etc

Issue : #111

Description

  1. Added config - kopf.config.WorkersConfig - class attributes based options to control async workers. So user can just import it before all other kopf modules and change values to required. Maybe not the best decision, but any.
  2. So now can be configured number of next types of workers: queue processing, object patching, event creation.
  3. Blocking synchronous operations such as event creation, changed objects patching, are now asynchronous (i guess).
  4. Added kopf.config.EventsConfig.events_loglevel to control what types of logs should trigger event sending - INFO/WARNING/ERROR/CRITICAL

Existing tests updated for new async functions.
E2E tests required to test performance(how fast large number of new/changed objects can be processed). Such tests would prove efficiency of kopf concurrency.

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Configuration change
  • Refactor/improvements

Tasks

List of tasks you will do to complete the PR

  • Documentation
  • E2E performance tests
  • Review?

Review

List of tasks the reviewer must do to review the PR

  • Tests (don't know if there could be tests to do)
  • Documentation (maybe?)

Commented by nolar at 2019-06-17 12:37:40+00:00
 

As a side-note: I tried to check why Travis CI pipeline is not triggered for this PR, and for this PR only — it works for other PRs & contributors. Travis CI says "Abuse detected" without any additional explanation.

I will try to contact Travis CI support to clarify what is the actual reason.

My only assumption for now is that this is a PR from the "master" branch of a fork to the "master" branch of the upstream — maybe Travis does not like it. This is the only "unusual" thing in this PR. Just guessing.

@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Some concurrency fixes, some configurability Aug 19, 2020
@kopf-archiver kopf-archiver bot added the refactoring Code cleanup without new features added label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive refactoring Code cleanup without new features added
Projects
None yet
Development

No branches or pull requests

0 participants