Resuming handler will not be retried if it fails

[kopf-archiver]

An issue by nolar at 2019-06-14 14:02:28+00:00
Original URL: zalando-incubator/kopf#113
 

Expected Behavior

When the @kopf.on.resume handler fails, it should be retried, as any other handlers.

Actual Behavior

(Only assumed, not checked):

If the @kopf.on.resume handler fails, it will not be retried.

If the @kopf.on.resume handler is not the first one, it will not be executed.

Cause: a handler failure (exception) causes the handler status to be stored on status.kopf.progress field via PATCH API call, which triggers the next event handling cycle, where the next handlers are attempted or the same handlers are retried. However, it will not be an initial listing already, so the cause detection will not recognise the resuming handler again.

Suggestion: store the status.kopf.initial state in case of failures, and take it into account when detecting causes. Once the full "initial" cycle is done, the whole status.kopf will be purged, and all further events will not include the resuming handler.

Specifications

kopf==0.16

ToDo:

• Verify if it is actually the behaviour.
• Fix it.
• Tests.

---

Commented by nolar at 2019-11-13 17:47:37+00:00
 

Solved with kopf==0.23rc1. See #230 for the details of the fixed on-resume handlers behaviour.