Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Move and split the modules (no code/logic changes) #155

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] Move and split the modules (no code/logic changes) #155

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive refactoring Code cleanup without new features added

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-07-24 10:59:59+00:00
Original URL: zalando-incubator/kopf#155
Merged by nolar at 2019-07-24 16:09:32+00:00

A preparation for switch to aiohttp and full-async.

Issue : #142

Description

In order to make the coming PRs easier to read with their diffs, this is a preparatory PR with no behaviour changes, no code modified, but only with the code moved across the modules.

As the code grows, some modules need to be split:

  • kopf.reactor.queueing is split into:
    • kopf.reactor.running for asyncio task management (starting and orchestration).
    • kopf.reactor.queueing for watch-event queueing and multiplexing only.

Other functions have to be moved for cohesion to their related functions:

  • watch_objs moved from kopf.clients.fetching to kopf.clients.watching (with the intention of reimplementing the watching & streaming).

The behaviour is NOT changed in any way.

Types of Changes

  • Refactor/improvements
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Move and split the modules (no code/logic changes) Aug 19, 2020
@kopf-archiver kopf-archiver bot added the refactoring Code cleanup without new features added label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive refactoring Code cleanup without new features added
Projects
None yet
Development

No branches or pull requests

0 participants