Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Remove the default peering for embeddable operator #174

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] Remove the default peering for embeddable operator #174

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive bug Something isn't working

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-08-08 13:00:50+00:00
Original URL: zalando-incubator/kopf#174
Merged by nolar at 2019-08-08 13:23:02+00:00

Issue : #142 #156

Description

Introduced implicitly in #156: When the operator was made embeddable, the defaults were not removed from the function signatures.

Normally, they were overridden by the CLI defaults and set to None. But not when the function was called as kopf.operator().

As a result, the embedded operator (kopf==0.21rc1) failed on startup due to a peering error (because the name was explicitly set, as if --peering=default was passed to CLI).

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Remove the default peering for embeddable operator Aug 19, 2020
@kopf-archiver kopf-archiver bot added the bug Something isn't working label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants