Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation hideOnClick + pagination hideOnClick - clicking one toggles the other. #4285

Closed
Fygo opened this issue Mar 1, 2021 · 0 comments
Closed

Comments

@Fygo
Copy link

@Fygo Fygo commented Mar 1, 2021

Hi there,

When both navigation hideOnClick and pagination hideOnClick are enabled, they interact with each other, kind of "cancelling" each other out:

  • clicking the navigation arrows shows/hides/shows/hides... the pagination
  • clicking the pagination does the same to the navigation

A quick look through the code shows these cases are not accounted for:

swiper.params.navigation.hideOnClick &&
        !$(e.target).is($prevEl) &&
        !$(e.target).is($nextEl)
      ) {

It is not checking anything about the pagination.
The same goes for the pagination-hiding if condition.

This is very distracting (and I actually think not intended). It would be really nice to keep both of them visible and not toggling one of them when the other one is clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant