Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'releaseOnEdges' option doesn't work #6770 #6799

Conversation

MohammadShehadeh
Copy link

@MohammadShehadeh MohammadShehadeh commented Jul 1, 2023

This PR aims to address the issue where the releaseonEdges option is not functioning as expected.

The releaseonEdges option is intended to control the release behavior when the user reaches the edge of the swiper container. However, in its current state, the functionality is not working correctly.

@nolimits4web
Copy link
Owner

Would be good to see the issue with CodeSandbox replication first, as i can't see issue with it

@MohammadShehadeh
Copy link
Author

Would be good to see the issue with CodeSandbox replication first, as i can't see issue with it

https://codesandbox.io/p/sandbox/swiper-react-mousewheel-control-forked-mn3fgk?file=%2Fsrc%2FApp.jsx%3A20%2C24

@nolimits4web
Copy link
Owner

Sorry, but i don't see any issues with it in the provided demo, everything is working

@MohammadShehadeh
Copy link
Author

MohammadShehadeh commented Jul 4, 2023

@nolimits4web please refers to the following video as you can see the default releaseOnEdges is not working

Screen.Recording.2023-07-04.at.11.49.52.AM.mov

@nolimits4web
Copy link
Owner

This is what i see

ss.mov

@MohammadShehadeh
Copy link
Author

MohammadShehadeh commented Jul 4, 2023

This is what i see

ss.mov

@nolimits4web yeah exactly the default is releaseOnEdges: false so the page shouldn't scroll when I reach the edge of the slider it should lock the scroll behavior while hovering over the slider

@nolimits4web
Copy link
Owner

Thank you, had to merge it manually as files are changed in current version

@MohammadShehadeh MohammadShehadeh deleted the fix/ReleaseOnEdges branch August 11, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants