Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual slides ignore initialSlide in the beginning #7353

Closed
5 of 6 tasks
m345054 opened this issue Mar 5, 2024 · 4 comments
Closed
5 of 6 tasks

Virtual slides ignore initialSlide in the beginning #7353

m345054 opened this issue Mar 5, 2024 · 4 comments
Labels
t0ggles Linked to the t0ggles task

Comments

@m345054
Copy link

m345054 commented Mar 5, 2024

Check that this is really a bug

  • I confirm

Reproduction link

https://jsfiddle.net/bqv2137n/11/

Bug description

When using initialSlide setting together with virtual, there is extra computing happening. Despite the value of initialSlide, Swiper currently always calls renderSlide with 0&1 indexes before rendering initialSlide slide. This is costly, when my createSlide() function is heavy.

--

Copied from #2755
This error still exists in v11.0.7

Expected Behavior

Console Output:

Slide 4
Slide 5
Slide 6

Actual Behavior

Console Output:

Slide 0
Slide 1
Slide 4
Slide 5
Slide 6

Swiper version

v11.0.7

Platform/Target and Browser Versions

Windows, Chrome

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@nolimits4web
Copy link
Owner

t0ggles-create swiper

Copy link

t0ggles bot commented Mar 19, 2024

Task nolimits4web/SWIPER-72 was created

t0ggles task SWIPER-72

@nolimits4web nolimits4web added the t0ggles Linked to the t0ggles task label Mar 28, 2024
Copy link

t0ggles bot commented Mar 28, 2024

Task nolimits4web/SWIPER-72 status changed to Done

@matichouraider
Copy link

@nolimits4web This doesn't work with React.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t0ggles Linked to the t0ggles task
Projects
None yet
Development

No branches or pull requests

3 participants