Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): centerInsuffientSlides takes offsets into account #7437

Merged

Conversation

slemling
Copy link
Contributor

@slemling slemling commented Apr 4, 2024

When using centerInsufficientSlides together with slidesOffsetBefore and slidesOffsetAfter, the slides won’t be centered correctly. Apparently slidesOffsetBefore and slidesOffsetAfter are not taken into account in the calculation of the offset for centerInsufficientSlides.

Codesandbox

Resolves #5436 (was closed already due to lacking information / activity, but issue still remains)

@nolimits4web
Copy link
Owner

t0ggles-create swiper

Copy link

t0ggles bot commented Apr 4, 2024

Task nolimits4web/SWIPER-86 was created

t0ggles task SWIPER-86

@t0ggles t0ggles bot added the t0ggles Linked to the t0ggles task label Apr 4, 2024
@sascha-eisenmann
Copy link

Hi @nolimits4web, I also ran into this problem. Any chance to get this released in the next few weeks?

@slemling Thanks for the fix. This saves me from building a messy workaround.

@slemling
Copy link
Contributor Author

Hey, any update here? It would be great to get a fix some time soon :)

@nolimits4web nolimits4web merged commit 5a271ff into nolimits4web:master May 13, 2024
Copy link

t0ggles bot commented May 13, 2024

Task nolimits4web/SWIPER-86 status changed to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t0ggles Linked to the t0ggles task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

centerInsufficientSlides doesn't count slidesOffsetBefore/slidesOffsetAfter params
3 participants