Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: missing 'lock' @output in Angular (again) #5439

Closed
5 of 6 tasks
xumepadismal opened this issue Feb 9, 2022 · 1 comment · Fixed by #5442
Closed
5 of 6 tasks

Regression: missing 'lock' @output in Angular (again) #5439

xumepadismal opened this issue Feb 9, 2022 · 1 comment · Fixed by #5442
Labels
Angular

Comments

@xumepadismal
Copy link

Check that this is really a bug

  • I confirm

Reproduction link

https://github.com/nolimits4web/swiper/pull/5225/files#diff-bfa627463b910d30122bd97c77f46167402610e987ac7922fb67145fb0104525L398

Bug description

It seems that after merging #5225 the @Output('lock') was removed by a mistake

Expected Behavior

No response

Actual Behavior

No response

Swiper version

8.0.3

Platform/Target and Browser Versions

any

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@vltansky vltansky mentioned this issue Feb 9, 2022
Merged
@vltansky
Copy link
Collaborator

vltansky commented Feb 9, 2022

Wow, that's awkward :)
Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Angular
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(angular): lock output vltansky/swiper
2 participants
@vltansky @xumepadismal