Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain max zoom to 100% of a slide's image size on the Zoom module #7303

Closed
4 tasks done
broox opened this issue Feb 10, 2024 · 0 comments · Fixed by #7311
Closed
4 tasks done

Constrain max zoom to 100% of a slide's image size on the Zoom module #7303

broox opened this issue Feb 10, 2024 · 0 comments · Fixed by #7311

Comments

@broox
Copy link
Contributor

broox commented Feb 10, 2024

Clear and concise description of the problem

A numeric maxRatio multiplier can be specified as an option on the Zoom module, which is great, however the image can scale past a reasonable resolution if the image is small. It would be nice to be able to specify a maxRatio of 100% of the original image.

Suggested solution

Allow a percentage to be passed into maxRatio, introduce a maxRatioPercentage property, or an optional boolean field to prevent zooming past 100% of the original image size.

Alternative

No response

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

  • I'm willing to open a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant