Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix management of sub-seconds in FitsDate #135

Merged
merged 2 commits into from Sep 24, 2021
Merged

Conversation

Zlika
Copy link
Contributor

@Zlika Zlika commented Nov 29, 2018

FitsDate does not manage correctly the sub-second part of a date.
The following strings are valid ISO-8601 dates that are not correctly parsed and generate an exception:

"2018-11-28T12:13:14.1"
"2018-11-28T12:13:14.1234"
"2018-11-28T12:13:14.123456"

This PR fixes this problem.

@attipaci
Copy link
Collaborator

attipaci commented Sep 1, 2021

I have incorporated the fixes from this pull request into an unofficial 1.1.5.3-AK2 release on my fork.

Also, in case you have any further fixes, I'll plan to keep regularly integrating pull requests made to the base repo, at least until the base repo is actively mainained again. (I could no longer bear that so many good fixes were unheeded here...)

@Zlika
Copy link
Contributor Author

Zlika commented Sep 1, 2021

Hi @attipaci. Thanks for your initiative. Do you plan to release this version on Maven central?

@attipaci attipaci merged commit e12ecf3 into nom-tam-fits:master Sep 24, 2021
@attipaci attipaci added this to the 1.16.0 milestone Sep 29, 2021
@attipaci attipaci added the bug Erroneous behavior of the existing code label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Erroneous behavior of the existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants