Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to CFITSIO hierarch specification #159

Merged
merged 2 commits into from Sep 28, 2021

Conversation

attipaci
Copy link
Collaborator

The CFITSIO hierarch specification requires a space before the hierarchical keyword and the equals sign following it, such as:

HIERARCH SMA OBS TARGET = 'venus' 

and CFITSIO will not be able to read FITS headers that skip the white space before =. A white space before = is certainly allowed by the original ESO HIERARCH convention, though not required therein. We should, however, add that space in the FITS headers we produce so they can be read back by CFITSIO. (And we can read HIERARCH keywords with or without space(s) before =).

@attipaci attipaci self-assigned this Sep 28, 2021
@attipaci attipaci added the bug Erroneous behavior of the existing code label Sep 28, 2021
@attipaci attipaci added this to the 1.16.0 milestone Sep 28, 2021
@attipaci attipaci linked an issue Sep 28, 2021 that may be closed by this pull request
@attipaci attipaci merged commit a9fd05b into nom-tam-fits:master Sep 28, 2021
@attipaci attipaci deleted the issue-87 branch September 28, 2021 17:18
@attipaci attipaci added enhancement A new feature and/or an improved capability standard Improved compliance to FITS standard labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Erroneous behavior of the existing code enhancement A new feature and/or an improved capability standard Improved compliance to FITS standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarch keywords convention
1 participant