Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inefficient FitsHeap #188

Closed
attipaci opened this issue Oct 29, 2021 · 0 comments · Fixed by #192
Closed

Inefficient FitsHeap #188

attipaci opened this issue Oct 29, 2021 · 0 comments · Fixed by #192
Assignees
@attipaci
Labels
enhancement A new feature and/or an improved capability
Milestone
1.16.0

Comments

@attipaci
Copy link
Collaborator

Currently, the way FitsHeap is implemented, it needs to construct a new BufferedInputStream every time it needs to go backwards to read data. This is very inefficient, even when used on byte arrays, since the heap does not have any particular organization, and should be fully random accessible. We need an implementation that provides true random access without unnecessary overheads.
@attipaci attipaci added the enhancement A new feature and/or an improved capability label Oct 29, 2021
@attipaci attipaci added this to the 1.16.0 milestone Oct 29, 2021
@attipaci attipaci self-assigned this Oct 29, 2021
@attipaci attipaci linked a pull request Nov 2, 2021 that will close this issue
Cleaned up the messy FITS IO hierarchy, and improved overall IO performance #192
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attipaci attipaci

Labels
enhancement A new feature and/or an improved capability
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Cleaned up the messy FITS IO hierarchy, and improved overall IO performance attipaci/nom-tam-fits
1 participant
@attipaci